D17453: [GCi 2018] GCompris: fix "erase" activities layout

Johnny Jazeix noreply at phabricator.kde.org
Sun Dec 9 17:27:44 GMT 2018

jjazeix added inline comments.


> Block.qml:47
> +    function getArg() {
> +        return higher ? 0.625 : 0.125

The name is not explicit, and it's complicated to understand what this function does.

> Erase.qml:140
> +            function getBottom() {
> +                if(parent.vert) {
> +                    items.higher = false

vert is not defined.
Also, it would be better to use qml bindings instead of a function in this case (so: "bottom: parent.vert ? background.bottom : bar.top)
and use directly parent.vert, instead of adding a "higher" variable.

  R2 GCompris


To: turx, #gcompris_improvements, jjazeix
Cc: kde-edu, jjazeix, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181209/7140729b/attachment-0001.html>

More information about the kde-edu mailing list