D17404: [GCI 2018] GCompris: Add keyboard controls support to Memory activities

Johnny Jazeix noreply at phabricator.kde.org
Sat Dec 8 19:44:57 GMT 2018


jjazeix added inline comments.

INLINE COMMENTS

> jjazeix wrote in memory.js:158
> sure, I'll take a look in one hour

var x = (i % columns) * items.grid.cellWidth + items.grid.anchors.margins
var y = (i / columns) * items.grid.cellHeight + items.grid.anchors.margins
items.grid.itemAt(x, y)

seems to be working (it has to be changed in getShownPair too at least).
However, I'm not sure on the exact culprit, but I've noticed the activity can freeze, if you keep pressing an arrow while you or Tux is winning a level :/. Not sure what can be the cause. Feel free to dig it, but if

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D17404

To: turx, #gcompris_improvements, jjazeix
Cc: jjazeix, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181208/42118927/attachment.html>


More information about the kde-edu mailing list