D16839: Force black pen when painting unstyled TextLabel

Alexander Semke noreply at phabricator.kde.org
Fri Dec 7 08:02:17 GMT 2018

asemke added a comment.

  In D16839#370541 <https://phabricator.kde.org/D16839#370541>, @asemke wrote:
  > In D16839#370476 <https://phabricator.kde.org/D16839#370476>, @asemke wrote:
  > > In D16839#365584 <https://phabricator.kde.org/D16839#365584>, @mikhailru wrote:
  > >
  > > > This text without formatting is painted with the default color, taken from the Qt theme. And this is the case which my original patch addressed.
  > >
  > >
  > > Ok. This makes sense. But let's use maybe the color QApplication::palette().color(QPalette::Active,QPalette::Text ) ) instead of hard-coded Qt::black.
  > Having thought more about this, for the unformatted text a better idea would to use Qt::black for the foreground color in case no theme is active and to use the foreground color from the theme, otherwise. Furthermore, for unformatted texts we shouldn't add any formatting when we apply a theme. At the moment we convert plain text to a html-formatted string which causes problems and is not required for plain text. It should be enough if we only set the proper pen color.
  I just pushed a change e3bafa4bac89a49a1ef58bfd78d17429750f1c45 <https://phabricator.kde.org/R262:e3bafa4bac89a49a1ef58bfd78d17429750f1c45> which should address many of these issues. @mikhailru  can you please check the current master? Applying different colors to different parts of the text and showing the correct color in the properties dock widget is still a problem in some cases. I'll check this.

  R262 LabPlot


To: mikhailru, #labplot
Cc: asemke, cfeck, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181207/a21fd4a8/attachment-0001.html>

More information about the kde-edu mailing list