D17377: keyboard binding support to "Money" based activities in gcompis

Aman Kumar Gupta noreply at phabricator.kde.org
Thu Dec 6 09:30:51 GMT 2018

amankumargupta added inline comments.


> MoneyCore.qml:137
> +                                color: "#88111111"
> +                                anchors.centerIn:parent
> +                                radius: 5

spaces before and after : symbol.

> MoneyCore.qml:298
>                              }
> +                            Rectangle{
> +                                width: parent.width * 1.1

space before {

> smitpatil wrote in MoneyCore.qml:338
> I first tried if-else but that took a lot of lines. Thus, I find switch more consistent than if-else. still, if you want, I will implement it.

Well, as far as I can see, the case statements will just be replaced with the if conditional statements. So, the number of lines should technically be around same :) You can once implement it and check ;)


To: smitpatil, #gcompris_improvements, amankumargupta
Cc: amankumargupta, kde-edu, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181206/036d8125/attachment.html>

More information about the kde-edu mailing list