D14942: Connect new-image event to Scheduler imaging time estimator.

Wolfgang Reissenberger noreply at phabricator.kde.org
Wed Aug 29 10:15:27 BST 2018


wreissenberger requested changes to this revision.
wreissenberger added a comment.
This revision now requires changes to proceed.


  I did some tests, looks good. There is one test that already failed in D14684 <https://phabricator.kde.org/D14684> and is still present. It might be exotic, but it leads to continuous looping.
  
  The setup is the following: create a schedule with two jobs for the same target with the same sequence job (say 1xLum for example). The first job starts and captures the first frame.
  
  And here is where the problem occurs: now calling //Scheduler::updateCompletedJobsCount()// detects the one frame, but when evaluating the second job (which did not run yet), the value in the captured frames map is overwritten. This leads to an endless loop of the first job.
  
  Here is a test case that demonstrates the problem: F6222844: testcases.tar.gz <https://phabricator.kde.org/F6222844>
  
  Copy the files into /tmp. The frames are stored in /var/tmp/kstars_tests

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D14942

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180829/3a1da34f/attachment.html>


More information about the kde-edu mailing list