D15137: Proper silencing for the switch-case fall-through warning
Eric Dejouhanet
noreply at phabricator.kde.org
Wed Aug 29 08:10:56 BST 2018
TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
TallFurryMan added a project: KDE Edu.
TallFurryMan requested review of this revision.
REVISION SUMMARY
This changeset silences the gcc warning for the case fall-through.
No idea if this will work without warning for msvc, but that doesn't change much compared to the previous state.
C++17 can use "<https://phabricator.kde.org/w/fallthrough/>;" to specify an execution path that intentionally falls through the following case.
Q_FALLTHROUGH was introduced in QT5.8, thus can't be used for Raspbian, still using QT5.4.
TEST PLAN
Without this change, gcc issues a warning on the case fall-through in function unParkMount.
With this change fall-through is acknlowledged and the warning doesn't appear.
REPOSITORY
R321 KStars
BRANCH
bugfix__proper_fallthrough_warning_silencing (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15137
AFFECTED FILES
kstars/ekos/scheduler/scheduler.cpp
To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180829/46cb8e80/attachment.html>
More information about the kde-edu
mailing list