D14965: Improve Scheduler robustness against INDI disconnections

Jasem Mutlaq noreply at phabricator.kde.org
Tue Aug 21 16:04:46 BST 2018


mutlaqja added a comment.


  When the scheduler attempts to connect to INDI again after a disconnection, is indiConnectionFailureCount reset? Will scheduler stop after it exhausts attempts MAX_FAILURE_ATTEMPTS or keeps looping forever?

INLINE COMMENTS

> scheduler.cpp:3181-3186
> +                // Let the Scheduler attempt to connect INDI again
>                  currentJob->setState(SchedulerJob::JOB_ABORTED);
> -                checkShutdownState();
> +                stopCurrentJobAction();
> +                stopGuiding();
> +                disconnectINDI();
> +                stopEkos();

Code appears to be repeated multiple times. Maybe make it into a function with descriptive name?

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D14965

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180821/c1755781/attachment-0001.html>


More information about the kde-edu mailing list