D14939: Making more recommended xplanet changes and fixing bugs:

[Robert Lancaster]

lancaster marked 3 inline comments as done.
lancaster added inline comments.

INLINE COMMENTS

> lancaster wrote in xplanetimageviewer.cpp:749
> Yeah, I wasn't sure what to do with that.  It was the way it was in server manager.cpp in KStars.  I can re-examine it.

Nope, I just went back and checked.  fd here is not a leaked object, it is simply an int, the return value of a computation.  It isn't the file or the filename.  If it is 0, that means the command succeeded and -1 means it failed.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D14939

To: lancaster, yurchor, pino, mutlaqja, kde-edu
Cc: kde-edu, mutlaqja, pino, yurchor, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180820/2c17d653/attachment-0001.html>