D14942: Connect new-image event to Scheduler imaging time estimator.

[Eric Dejouhanet]

TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  This change connects the Scheduler to the new-image signal sent by the Capture module.
  It triggers a refresh of the capture storage, and updates the time estimation of all jobs.
  This can't be a simple +1 in the count of the running job because of duplicates.
  Note that ANY new-image coming from the Capture module will trigger a refresh, even if the Scheduler is not running.
  This is not expected to be an issue as currently all jobs, whatever their state (even being edited), can be re-evaluated without issue.

TEST PLAN
  Create a scheduler job list, with or without duplicates, using sequence jobs with or without duplicates.
  Run the Scheduler, check capture counts are properly updated (beware, that can be quite difficult to follow in complex cases).
  Without the change, no capture count is updating.
  With the change, relevant capture counts update, as well as imaging durations, resulting in proper evaluation of imaging time left (yay!).
  
  There's an issue that raises from this test, but not exactly a real issue, more a consequence of the implementation.
  
  Because the Capture module has options to add a Filter and a Duration suffix (and that those options are effectively optional),
  and because the Scheduler is recognizing capture files from the beginning of the file *name*, captures without suffix *and* captures with
  suffix will be counted for a scheduler job using a sequence *without* suffix. On the opposite, a scheduler job using a sequence *with*
  suffix will not count capture files *without* suffix.
  
  If we really want to fix that issue all the way through, we need to look into the FITS header to match the capture file with the sequence
  properties. Do we need to go there now?

REPOSITORY
  R321 KStars

BRANCH
  improve__scheduler_image_update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14942

AFFECTED FILES
  kstars/ekos/ekosmanager.cpp
  kstars/ekos/scheduler/scheduler.cpp
  kstars/ekos/scheduler/scheduler.h

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180820/fa0e8a6f/attachment.html>