D14738: Add the markdown entry
Filipe Saraiva
noreply at phabricator.kde.org
Wed Aug 15 11:43:14 BST 2018
filipesaraiva added a comment.
In D14738#309525 <https://phabricator.kde.org/D14738#309525>, @pino wrote:
> In D14738#309519 <https://phabricator.kde.org/D14738#309519>, @filipesaraiva wrote:
>
> > Can I change the authorship of the commit and push now? Do you know @pino?
>
>
> You definitely cannot change already pushed commits...
>
> 1. revert the commit, because of wrong authorship, and unfixed issues still there
> 2. wait for @kqwyf to fix the issues
> 3. once it is done, ask him/her for name and email (since silly phabricator cannot provide this info for commits sent with arc)
> 4. take the patch, amend it fixing the authorship, and push
Ok, thanks for answer @pino. The e-mails of this review was stored in a different folder of my mailbox, because it I thought nobody was asking for more changes.
Sorry again, and please continue the review guys, I will fix it when everyone has approved.
REPOSITORY
R55 Cantor
REVISION DETAIL
https://phabricator.kde.org/D14738
To: kqwyf, pino, #cantor, filipesaraiva
Cc: sirgienko, filipesaraiva, pino, asemke, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180815/2c45745b/attachment.html>
More information about the kde-edu
mailing list