D14738: Add the markdown entry
Yifei Wu
noreply at phabricator.kde.org
Tue Aug 14 18:26:11 BST 2018
kqwyf added a comment.
In D14738#309034 <https://phabricator.kde.org/D14738#309034>, @pino wrote:
> Nitpick: please provide a consistent indentation in the new files -- they seem to mix spaces and tabs.
> Also, was this tested when cantor is built without the Discount library? How does it behave when trying to add/edit markdown entries, and trying to load worksheets with such entries?
When it is build without the Discount library, the markdown entries behave just like text entries when trying to add/edit/load them.
Another bug was found: when re-editing a markdown entry in a Cantor without Discount library, the latex code will disappear. This is because some variables (e.g. `html`) and codes only for markdown renderring are still in use. I will include all the overridden functions in `#ifdef`. This way it will work just as the TextEntry.
Sorry but I'm not sure about the rule to bump the ui version number. What number should it become? Maybe `2.1`?
REPOSITORY
R55 Cantor
REVISION DETAIL
https://phabricator.kde.org/D14738
To: kqwyf, pino, #cantor, filipesaraiva
Cc: sirgienko, filipesaraiva, pino, asemke, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180814/a528b735/attachment-0001.html>
More information about the kde-edu
mailing list