D14738: Add the markdown entry
Yifei Wu
noreply at phabricator.kde.org
Tue Aug 14 16:39:30 BST 2018
kqwyf added a comment.
In D14738#308508 <https://phabricator.kde.org/D14738#308508>, @filipesaraiva wrote:
> Thank you for your contribution @kqwyf. I built with Discount and it is working fine. I built without Discount, I could run Cantor correctly and the options to insert Markdown entries continues to show, but it is a problem with others entries options like LaTeX. Maybe it is time to some refactoring in this part.
>
> For a first contribution it is very good, congrats. Stay with us to develop more features and fix bugs. :)
>
> I will wait some hours for comments of the others reviewers, if they are nothing to ask I will push to you.
I think it a bit hard for me to refactor this part. I probably can't do it in this patch.
In D14738#308802 <https://phabricator.kde.org/D14738#308802>, @sirgienko wrote:
> If I insert Markdown entry from context menu (this menu also have "Evaluate Worksheet" action) in the end of worksheet and click after it, a command entry added. Could anyone reproduce it?
I didn't notice it when I was testing. Thank you for reporting this bug. It is fixed.
REPOSITORY
R55 Cantor
REVISION DETAIL
https://phabricator.kde.org/D14738
To: kqwyf, pino, #cantor, filipesaraiva
Cc: sirgienko, filipesaraiva, pino, asemke, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180814/1c9d8cdd/attachment.html>
More information about the kde-edu
mailing list