D14684: Fixes for the Scheduler and Capture modules

[Eric Dejouhanet]

TallFurryMan added a comment.


  In D14684#308195 <https://phabricator.kde.org/D14684#308195>, @wreissenberger wrote:
  
  > @TallFurryMan: I did not run the entire test set yet, but my problem mentioned on Fri, Aug 10, 2:19 PM still exists. The attached test case illustrate the wrong behavior.
  >
  > In D14684#306156 <https://phabricator.kde.org/D14684#306156>, @wreissenberger wrote:
  >
  > > Not sure whether the problem still exists after your changes, but I found a situation where the scheduler loops endlessly.
  > >
  > > If you have two jobs with the same capture file signature (path + filter etc.) and the **second** has **less** repeats than the first, the first job will repeat endlessly.
  > >
  > > The problem is that Scheduler::updateCompletedJobsCount() overwrites the map entry such that a later evaluation thinks that it has less captures than requested.
  > >
  > > Please find included a test illustrating it. Place it under /tmp/kstars_tests
  > >
  > > -Wolfgang
  > >
  > > F6185585: tests.tar.gz <https://phabricator.kde.org/F6185585>
  >
  >
  > -Wolfgang
  
  
  I did test that and there was no issue. Let me try again.
  
  Thank you Jasem, I'll move on.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D14684

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180814/4d5fe068/attachment.html>