D14712: Play_piano activity

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> PlayPiano.qml:82
> +            if(piano.whiteKeysEnabled && !iAmReady.visible) {
> +                if(event.key >= Qt.Key_1 && event.key <= Qt.Key_8) {
> +                    piano.keyRepeater.itemAt(keyboardBindings[event.key]).whiteKey.keyPressed()

instead of duplicating the check on the key values, you can have isWhiteKeyPressed and isBlackKeyPressed functions, each one having its keys

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D14712

To: amankumargupta, #gcompris_activities
Cc: jjazeix, kde-edu, #gcompris_activities, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180813/39794abc/attachment.html>