D14727: piano_composition activity

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> ActivityInfo.qml:52
> +  section: "discovery sound_group"
> +}

createdInVersion

> OptionsRow.qml:132
> +        GCText {
> +            text: multipleStaff.bpmValue + " BPM"
> +            width: 0.6 * parent.width

qsTr()

> Piano_composition.qml:25
> +import QtQuick 2.6
> +import QtQuick.Controls 1.0
> +import GCompris 1.0

version

> Piano_composition.qml:113
> +                    keyNumber--
> +                if(!keyNumber)
> +                    piano.keyRepeater.itemAt(i).blackKey.keyPressed()

no ! for comparing int

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D14727

To: amankumargupta, #gcompris_activities
Cc: jjazeix, kde-edu, #gcompris_activities, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180810/fced7bcc/attachment.html>