D14713: Play_rhythm activity

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> ActivityInfo.qml:40
> +  //: Help manual
> +  manual: qsTr("Listen to the rhythm played, and follow along with the music. If you would like to hear it again, click the play button. When you're ready to perform the identical rhythm, click the drum to the rhythm. If you clicked correctly and in the right tempo, another rhythm is displayed. If not, you must try again.<br>Even levels display a vertical playing line when you click the drum, which helps you see when to click to follow the rhythm. Click on the drum when the line is in the middle of the notes.<br>Odd levels are harder, because there is no vertical playing line. You must read the rhythm, and click it back in tempo. Click the metronome to hear the quarter note tempo.")
> +  credit: ""

if you want to hear it again.

> PlayRhythm.qml:285
> +
> +        OptionsRow {
> +            id: optionsRow

unused?

> play_rhythm.js:67
> +        var accuracyLowerLimit = items.multipleStaff.musicElementRepeater.itemAt(currentNote).x
> +        var accuracyUpperLimit = accuracyLowerLimit + items.multipleStaff.musicElementRepeater.itemAt(currentNote).width
> +        if(pulseMarkerX >= accuracyLowerLimit && pulseMarkerX <= accuracyUpperLimit)

I think you should not base the accuracy on the width of the items but on the time +/- an error margin

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D14713

To: amankumargupta, #gcompris_activities
Cc: jjazeix, kde-edu, #gcompris_activities, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180809/fad71a6e/attachment.html>