D14665: Edit scheduler jobs with double-click and update icon to match Capture module.

[Eric Dejouhanet]

TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
Restricted Application added a project: KDE Edu.
Restricted Application added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  Add move buttons, refactor button state changes.
  
  This change required refactoring to avoid mixing up button states. I
  believe this is too opaque for its own good. The scheduler UI states
  should be moved to their own state machine, QML perhaps?

TEST PLAN
  Create a multi-job scheduler list, with some jobs that will start asap, others that will start later on.
  Double-click to edit jobs, check that single-click will only select.
  Observe that the end-user may click to edit, but observe that fields would not match job line in that case, so learning curve is probably relatively flat for this change.
  Check add button changes to apply when editing, check other button states.
  Change fields, check validation actually change fields.
  [BUG] Note the bug with RA/DEC fields, which do not update the job properly. Another change which triggers a save is required to have it work properly.
  Click to select a job, move it up and down, check other jobs re-evaluate properly.
  Fill fields for a new job, click to select a job, add the new job, new job should be inserted before the selected job.
  [SHOULD WORK, NOT TESTED] Observe schedule inversion when two jobs that can start now change order.
  [SHOULD WORK, NOT TESTED] Double-click a job to edit it, change a field, select another job without validating, apply changes, proper job should update.
  Check button states and evaluation when loading a scheduler list from a file.
  [BUG] Note that sometimes no line is selected, but it's still possible to move jobs.

REPOSITORY
  R321 KStars

BRANCH
  improve__homogeneize_scheduler_capture_edition_modes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14665

AFFECTED FILES
  kstars/ekos/scheduler/scheduler.cpp
  kstars/ekos/scheduler/scheduler.h
  kstars/ekos/scheduler/scheduler.ui
  kstars/ekos/scheduler/schedulerjob.h

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180807/c4a542b7/attachment.html>