D14586: Mark scheduler job dirty when succesfully changing its target.

Eric Dejouhanet noreply at phabricator.kde.org
Fri Aug 3 21:35:55 BST 2018


TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
Restricted Application added a project: KDE Edu.
Restricted Application added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  When editing a scheduler job, call setDirty when target is selected from the pop-up list.
  The target and RA/DEC boxes were only triggering the job update when editing the text and leaving the field.
  When the pop-up list was used, the programmatic update of those fields wasn't triggering that update.
  
  This fixes the use case where the end-user is looking for a target to start in ASAP mode.
  In that use case, the end-user will select targets and observe the starting date/time the Scheduler computed.

TEST PLAN
  Create a Scheduler job.
  Click its line in the job table once to edit it, and click the search button.
  Choose another target, the target and RA/DEC fields reflect the update.
  Click the add/save-job button.
  Prior to this fix, the job would not be updated in the queue table.
  With this fix, the job is properly updated.

REPOSITORY
  R321 KStars

BRANCH
  bugfix__search_does_not_call_setDirty (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14586

AFFECTED FILES
  kstars/ekos/scheduler/scheduler.cpp

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180803/48941995/attachment.html>


More information about the kde-edu mailing list