D12565: Improve octave login

[Nikita Sirgienko]

sirgienko added a comment.


  In D12565#255334 <https://phabricator.kde.org/D12565#255334>, @asemke wrote:
  
  > Yes, this all is a bit inconsistent in Cantor for different backends. I'd rather go for a solution where all the initial stuff is done in login() only. So, parsing of the promt, if required, emitting of signals etc. should be done in login(). This is the case for example in juliasession.cpp where the output is read until "ready" comes. parseOutput() should be used for parsing of the expression outputs only. This would lead to a more clear and consistent architecture in Cantor. Once this is done in octavesession, this should also solve the problem you propose to fix here.
  
  
  Well, I think I have understood you now, so I remove the emit changes and will start to work on solution, which have all init logic in login and don't return, until all preparation will be done.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D12565

To: sirgienko, #cantor, asemke
Cc: #cantor, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180428/ba910ab6/attachment.html>