D12567: Avoid octave backend crushing, when we try to kill ended process

[Alexander Semke]

asemke added a comment.


  In D12567#255094 <https://phabricator.kde.org/D12567#255094>, @sirgienko wrote:
  
  > In D12567#255054 <https://phabricator.kde.org/D12567#255054>, @asemke wrote:
  >
  > > Shouldn't this check if(m_process->state() != QProcess::NotRunning) be done in a central place so that this logic applies for all backends? It shoudln't be possible to call the interrupt action in worksheet or in cantor_shell/part at all if the process is not running. But we can maybe also safe-guard this in all the *session.cpp files.
  >
  >
  > I have checked all session files, and all the files, except `octavesession.cpp`, or have has existence checking before kill the process or even haven't killed the process.
  
  
  I don't see such a check in maximasessin.cpp. But ok, let's safe-guard everywhere.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D12567

To: sirgienko, #cantor, asemke
Cc: #cantor, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180428/4b941788/attachment-0001.html>