D12567: Avoid octave backend crushing, when we try to kill ended process

[Nikita Sirgienko]

sirgienko added a comment.


  In D12567#255054 <https://phabricator.kde.org/D12567#255054>, @asemke wrote:
  
  > Shouldn't this check if(m_process->state() != QProcess::NotRunning) be done in a central place so that this logic applies for all backends? It shoudln't be possible to call the interrupt action in worksheet or in cantor_shell/part at all if the process is not running. But we can maybe also safe-guard this in all the *session.cpp files.
  
  
  I have checked all session files, and all the files, except `octavesession.cpp`, or have has existence checking before kill the process or even haven't killed the process.
  
  > calling quit() in an octave session results in a permanent "Calculating..." message in the status bar. Clicking on the interrupt crashes cantor. This problem is a bit similar to https://bugs.kde.org/show_bug.cgi?id=372075.
  
  It look similar, but I don't think, that they have same reason. Python2 doesn't use process, it uses python binding for c++. And I think, the problem, that we run python command without checking python status, so then the problem arise, when we run `print(quit())` after `quit()`.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D12567

To: sirgienko, #cantor, asemke
Cc: #cantor, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180428/04684360/attachment-0001.html>