D12074: Solve problem of appearance input of interpreter in interpreter's output in Lua backend

[Alexander Semke]

asemke added a comment.


  In D12074#254487 <https://phabricator.kde.org/D12074#254487>, @sirgienko wrote:
  
  > In D12074#254482 <https://phabricator.kde.org/D12074#254482>, @asemke wrote:
  >
  > > Do you agree?
  >
  >
  > Well, I agree, maybe it's better to come back to this later. Just in case I want to notice, that your `lua_multiline_output_3.patch` don't handle output from commands like `print('> ')`. I think, we should solve this problem in the final solution,
  
  
  I created a bug report for this problem in order not to forget about it - https://bugs.kde.org/show_bug.cgi?id=393579.
  For the problem with the auto evaluation mode I created https://bugs.kde.org/show_bug.cgi?id=393580.
  
  > And that about lua tests? What results do you get with patch 3?
  
  You skipped already the problematic tests in D11791 <https://phabricator.kde.org/D11791>. We'll need to check this, too.
  
  I extended a bit the description in T3872 <https://phabricator.kde.org/T3872> with "Test loading of saved projects - open a project, execute all commands and check the outputs. Test with and without "auto evaluation" option enabled.". The test project file you used here covers quite a lot of different features and we should create couple of tests with it. In LabPlot we have already tests for the project load/import - load a saved project and check its content (https://cgit.kde.org/labplot.git/tree/tests/import_export/project/ProjectImportTest.cpp). Would be great to add similar tests in Cantor too.
  
  We can close this code review ticket. The situation with lua was greatly improved now. All the remaining open issues will be addressed in other tickets/reviews.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D12074

To: sirgienko, #cantor, asemke
Cc: #cantor, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180427/b3eaf741/attachment.html>