D12425: programmingMaze, code clean-up final revision

Johnny Jazeix noreply at phabricator.kde.org
Sun Apr 22 19:27:39 UTC 2018


jjazeix added inline comments.

INLINE COMMENTS

> programmingMaze.js:206
> +        // Create procedure object in the main look-up table ,if the level has procedure/loop, to execute it for procedure/loop calls from the main code area.
> +        mainInstructionObjects[CALL_PROCEDURE] = instructionComponents[CALL_PROCEDURE].createObject(items.background)
> +        mainInstructionObjects[CALL_PROCEDURE].foundDeadEnd.connect(items.background.deadEnd)

can you create a createInstruction that will create the object and connect the signals to factorise the code?
It will be used here and in the createInstructionObjects function

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D12425

To: amankumargupta, #gcompris_improvements
Cc: jjazeix, #kde_edu, #gcompris_improvements, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180422/c7f5ab0e/attachment.html>


More information about the kde-edu mailing list