D12425: programmingMaze, code clean-up final revision

[Aman Kumar Gupta]

amankumargupta created this revision.
amankumargupta added a reviewer: GCompris: Improvements.
amankumargupta added a project: GCompris: Improvements.
Restricted Application added a subscriber: KDE Edu.
Restricted Application added a project: KDE Edu.
amankumargupta requested review of this revision.

REVISION SUMMARY
  This diff mainly focuses on generalizing the object creation, destroying and accessing process of the instruction objects while executing the user's code.
  
  Previously, the  object creation and destroying code for both didn't follow the same process/behaviour. In this diff, the code have been refactored to have same behaviour and the other changes which are very important for the extension for **programmingMaze loops* activity.
  
  Now we maintain two look-up tables for main and procedure respectively and we create the instructions for each at the starting of the levels and they can be accessed to execute the instruction when needed, and destroyed at the end of the level (which was previously done only for procedure).
  
  This is certainly better, more readible, and most importantly having the code to follow the same behaviour for both.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D12425

AFFECTED FILES
  src/activities/programmingMaze/Dataset.qml
  src/activities/programmingMaze/ProgrammingMaze.qml
  src/activities/programmingMaze/instructions/Procedure.qml
  src/activities/programmingMaze/programmingMaze.js

To: amankumargupta, #gcompris_improvements
Cc: #kde_edu, #gcompris_improvements, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180421/67b589ed/attachment-0001.html>