D12310: Keyboard control support [T8492]

[Aman Kumar Gupta]

amankumargupta added inline comments.

INLINE COMMENTS

> Lightsoff.qml:204
>  
> -                    BarButton {
> -                        anchors.fill: parent
> -                        fillMode: Image.PreserveAspectFit
> -                        source: Activity.url + "off.svg"
> -                        opacity: lighton === 1 ? 0 : 1
> -                        z: lighton === 1 ? 10 : 11
> -                        sourceSize.height: items.cellSize
> -                        onClicked: {
> -                            activity.audioEffects.play('qrc:/gcompris/src/core/resource/sounds/scroll.wav')
> -                            Activity.switchLight(index)
> +                BarButton {
> +                    anchors.fill: parent

Can these two BarButton be refactored into one?

REVISION DETAIL
  https://phabricator.kde.org/D12310

To: harrymecwan, #gcompris_improvements
Cc: amankumargupta, #kde_edu, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180418/1902cb02/attachment.html>