D12296: QT-style Score/Altitude/Priority comparisons

[Eric Dejouhanet]

TallFurryMan created this revision.
TallFurryMan added a reviewer: mutlaqja.
Restricted Application added a subscriber: KDE Edu.
Restricted Application added a project: KDE Edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  This change moves the score/altitude/priority comparisons to SchedulerJob,
  keeping the lessThan QT-style sort predicate implementation, but clarifying the
  intended order.
  
  Accompanying documentation in SchedulerJob.h is perhaps a bit larger for these
  functions than for the rest of SchedulerJob, but more documentation should come
  anyway.
  
  FIXME to remind to refactor scheduler job sorting in one separate function.
  FIXME to indicate there is probably a wrong sort on score.
  FIXME to use std::sort because qSort is deprecated, but that's minor.

TEST PLAN
  There is no change in functionality involved by this change.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D12296

AFFECTED FILES
  kstars/ekos/scheduler/scheduler.cpp
  kstars/ekos/scheduler/schedulerjob.cpp
  kstars/ekos/scheduler/schedulerjob.h

To: TallFurryMan, mutlaqja
Cc: #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180417/70edbcff/attachment.html>