D11357: Provide global config to set number to expose children to(ref: T3173)

Johnny Jazeix noreply at phabricator.kde.org
Mon Apr 16 12:11:42 UTC 2018


jjazeix added inline comments.

INLINE COMMENTS

> Gletters.qml:176
> +                                value: items.numberLimit
> +                                onValueChanged: numberLimitText.text = qsTr("Maximum Number Limit: " + value)
> +                                scrollEnabled: false

do you really need to update it there? Shouldn't the binding do the job by itself?

> Gletters.qml:181
> +                                id: numberLimitText
> +                                text: qsTr("Maximum Number Limit: " + numberLimitSlider.value)
> +                                fontSize: mediumSize

qsTr().arg

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D11357

To: rohitdas, #gcompris_improvements, jjazeix
Cc: echarruau, jjazeix, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180416/2075bd00/attachment.html>


More information about the kde-edu mailing list