D12188: Save and delete a user

[Johnny Jazeix]

jjazeix added a comment.


  I can't run the fix:
  qrc:/gcompris/src/server/views/UsersManagement.qml:302:9: Type AddUpdateUser unavailable
  qrc:/gcompris/src/server/views/AddUpdateUser.qml:163:30: Expected token `,'

INLINE COMMENTS

> AddUpdateUser.qml:44
>          height: parent.height - (bar.height * 2)
> +        property var name: "";
> +        property var dateOfBirth: ""

string

> AddUpdateUser.qml:48
> +
> +        function save(){
> +

coding convention

> AddUpdateUser.qml:101
>              delegate: Item {
> -                width: passwordColumn.height
> -                height: 50 // same as rowDelegate
> +                id: pc
> +                width: passwordColumn.width // same as rowDelegate

passwordColumn

> AddUpdateUser.qml:147
> +                        anchors.rightMargin: 10
> +                        Text{
> +                            anchors.centerIn: parent

GCText

> AddUpdateUser.qml:150
> +                            color: "white"
> +                            text: "Save"
> +                        }

qsTr()

> AddUpdateUser.qml:222
>  
> -                        onActiveFocusChanged: {
> -                            if (!activeFocus) {
> -                                switch(styleData.column) {
> -                                    case 0:
> -                                    userToUpdateModel.get(styleData.row).name = text
> +                        onEditingFinished:{
> +                            console.log("finished editing")

the aim was to be able to add multiple users at same time, not just one

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D12188

To: rishabhg, jjazeix, timotheegiet
Cc: #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180414/03329afd/attachment.html>