D11992: Fix bad performance for `addRules` in `DefaultHighlighter` for big containers

[Nikita Sirgienko]

sirgienko updated this revision to Diff 31575.
sirgienko added a comment.


  In D11992#241763 <https://phabricator.kde.org/D11992#241763>, @asemke wrote:
  
  > Can we try to implement this with a boolean paramer m_suppressRuleChangedSignal instead of adding new functions? In addRules() we set m_suppressRuleChangedSignal = true and use in addRule()
  >
  >   if (!m_supressRuleChangedSignal)
  >        emit rulesChanged();
  >
  >
  > The code will be more compact and clean with this. Also, this would be similar to the convention we use in LabPlot <https://phabricator.kde.org/project/profile/56/>.
  
  
  Done

REPOSITORY
  R55 Cantor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11992?vs=31514&id=31575

REVISION DETAIL
  https://phabricator.kde.org/D11992

AFFECTED FILES
  src/lib/defaulthighlighter.cpp
  src/lib/defaulthighlighter.h

To: sirgienko, #cantor, asemke
Cc: #cantor, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180407/e839ee29/attachment.html>