D11962: Fix problems with unnesesary unsaved empty entries when load worksheet from file
Nikita Sirgienko
noreply at phabricator.kde.org
Thu Apr 5 14:46:07 UTC 2018
sirgienko created this revision.
sirgienko added reviewers: Cantor, asemke.
sirgienko added a project: Cantor.
Restricted Application added a subscriber: KDE Edu.
Restricted Application added a project: KDE Edu.
sirgienko requested review of this revision.
REVISION SUMMARY
Before, if you save worksheet and load it, you have see, that after each line have added empty entry. It happens, because command entry after placing result checks existence next entry. If entry don't exist, the command entry add new empty command entry, so worksheet always have empty entry on the end of the worksheet. But when we load entries from file, we haven't empty entry on the end, because we place entries one by one. So each time, when we place command from file, the command after placing result (from file too) add empty entry. It fix this problem by adding check before adding empty entry, that we don't load entries from file.
TEST PLAN
1. Write multiline worksheet
2. Save it
3. Close it
4. Open it
5. Checks, that there aren't unnesesary empty entries.
REPOSITORY
R55 Cantor
REVISION DETAIL
https://phabricator.kde.org/D11962
AFFECTED FILES
src/worksheet.cpp
src/worksheet.h
src/worksheetentry.cpp
To: sirgienko, #cantor, asemke
Cc: #cantor, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180405/29a655e4/attachment.html>
More information about the kde-edu
mailing list