D7852: Progress bar corresponding to clicked zone only will be animated

Divyam Madaan noreply at phabricator.kde.org
Fri Oct 27 14:25:40 UTC 2017


dmadaan added inline comments.

INLINE COMMENTS

> GoalZone.qml:90
> +                ball.state = "FAIL"
> +            }
> +            timerBonus.start()

ball.state = progress.ratio > 100 ? items.saveBallState : "FAIL" ?

> Penalty.qml:94
> +            property double ballX: ball.parent.width/2 - ball.width/2;
> +            property double ballY: ball.parent.height*0.77 - ball.height/2
>          }

space before and after "*" and "/"

> penalty.js:34
>      currentLevel = 0
> +
>      initLevel()

why this empty line inserted?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D7852

To: rohitdas, #gcompris_improvements, #gcompris, rudranilbasu
Cc: rudranilbasu, dmadaan, #kde_edu, jjazeix, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20171027/5f3b3c48/attachment.html>


More information about the kde-edu mailing list