D7852: Progress bar corresponding to clicked zone only will be animated

Rudra Nil Basu noreply at phabricator.kde.org
Sun Oct 22 14:07:08 UTC 2017


rudranilbasu requested changes to this revision.
rudranilbasu added a comment.
This revision now requires changes to proceed.


  Looks good, I made few inline comments for some minor changes.

INLINE COMMENTS

> GoalZone.qml:1
> +/* GCompris - Zone.qml
> +*

"Zone.qml" => "GoalZone.qml"

> GoalZone.qml:62
> +
> +        //var saveBallState = MyRectangle.state
> +        if(ball.state === "FAIL") {

Can it be deleted it if it is not needed?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D7852

To: rohitdas, #gcompris_improvements, #gcompris, rudranilbasu
Cc: rudranilbasu, dmadaan, #kde_edu, jjazeix, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20171022/d2eafff8/attachment.html>


More information about the kde-edu mailing list