D8859: Adapt the cmake buildsystem to be able to work with KDE CI

Csaba Kertész noreply at phabricator.kde.org
Wed Nov 29 13:55:24 UTC 2017


ckertesz added a comment.


  Thanks for the update!
  
  - libraw: fails to build because the swab-workaround is still needed on desktop otherwise:
  
  [ 14%] Building CXX object CMakeFiles/raw.dir/internal/dcraw_common.cpp.o
  .../kstars/build_android/android/3rdparty/libraw/internal/dcraw_common.cpp:211:5: error: use of undeclared identifier 'swab'
  
    swab ((char*)pixel, (char*)pixel, count*2);
    ^
  
  .../kstars/build_android/android/3rdparty/libraw/internal/dcraw_common.cpp:13760:7: error: use of undeclared identifier 'swab'
  
    swab ((char*)ppm2, (char*)ppm2, width*colors*2);
    ^
  
  2 errors generated.
  
  - cfitsio: There is no sane reason, but CMake can't determinate the static linker correctly (even if -DCMAKE_AR is passed in configuration stage), if the toolchain file is not included in the cfitsio/CMakeLists.txt,. Please don't remove the following workaround line from the cfitsio patch:
  
  include(${CMAKE_TOOLCHAIN_FILE})
  
  I look forward for the next round.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D8859

To: apol, mutlaqja
Cc: ckertesz, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20171129/ae240655/attachment.html>


More information about the kde-edu mailing list