Review Request 123968: Simplify Finding GSL in CMake
David Narváez
david.narvaez at computer.org
Sat Mar 18 10:37:47 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123968/
-----------------------------------------------------------
(Updated March 18, 2017, 10:37 a.m.)
Status
------
This change has been discarded.
Review request for KDE Edu and Marko Käning.
Repository: labplot
Description
-------
Use the PkgConfig module. Setting compile definitions HAVE_GSL and GSL_VERSION has no effect in the code so I removed them.
Diffs
-----
CMakeLists.txt 980909c5b7b3effe70f0478f5e2128870f342e8f
src/CMakeLists.txt a70299a6b29dbf6703d255f7b9b1c05b4a457da1
Diff: https://git.reviewboard.kde.org/r/123968/diff/
Testing
-------
Compiled with make VERBOSE=1 to see the compile commands. I am not sure if this still works in the OSX configuration, Marko?
Thanks,
David Narváez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20170318/15e5118d/attachment.html>
More information about the kde-edu
mailing list