Review Request 130124: parley: Add locale name to column title

Dimitris Kardarakos dimkard at gmail.com
Thu Jul 27 09:12:05 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130124/
-----------------------------------------------------------

(Updated July 27, 2017, 9:12 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu.


Changes
-------

Submitted with commit cdfe6f61218e3d71918995611fafa38d07de12ea by Albert Astals Cid on behalf of Dimitris Kardarakos to branch master.


Repository: parley


Description
-------

In editor mode, when the same column is displayed, coming from different languages, it is impossible to find out the source language. E.g. when Word Type is visible, for both English and Spanish, both columns are displayed as Word Type, at the header of the table. In terms of this solution, locale name has been added to each column title (since it is more compact than language name).


Diffs
-----

  src/collection/vocabularymodel.h 846f39b 
  src/collection/vocabularymodel.cpp 582701b 
  src/editor/vocabularycolumnsdialog.cpp fc08c1e 

Diff: https://git.reviewboard.kde.org/r/130124/diff/


Testing
-------

Collections have been edited and practiced and everything worked as expected.


File Attachments
----------------

Columns before
  https://git.reviewboard.kde.org/media/uploaded/files/2017/05/10/23f51bc0-e4a9-4372-a03f-6207d467fc95__parley_before.png
Columns after
  https://git.reviewboard.kde.org/media/uploaded/files/2017/05/10/e4990fd0-c78b-44b8-a0ca-ec9a781080bc__parley_after.png


Thanks,

Dimitris Kardarakos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20170727/eca0815c/attachment.html>


More information about the kde-edu mailing list