Review Request 130124: parley: Add locale name to column title

[Yuri Chornoivan]

> On Липень 2, 2017, 10:29 після полудня, Albert Astals Cid wrote:
> > src/collection/vocabularymodel.cpp, line 293
> > <https://git.reviewboard.kde.org/r/130124/diff/1/?file=495659#file495659line293>
> >
> >     You're assuming all the languages in the world want the locale at the end, use %1
> 
> Dimitris Kardarakos wrote:
>     Please elaborate because I don't understand.

To avoid confusions with suffix position in RTL languages and languages with different word order it is good to give translators an ability to change the word order as they like. Something like

i18n("Pronunciation %1", localeSuffix);


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130124/#review103400
-----------------------------------------------------------


On Травень 10, 2017, 9:44 до полудня, Dimitris Kardarakos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130124/
> -----------------------------------------------------------
> 
> (Updated Травень 10, 2017, 9:44 до полудня)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> In editor mode, when the same column is displayed, coming from different languages, it is impossible to find out the source language. E.g. when Word Type is visible, for both English and Spanish, both columns are displayed as Word Type, at the header of the table. In terms of this solution, locale name has been added to each column title (since it is more compact than language name).
> 
> 
> Diffs
> -----
> 
>   src/collection/vocabularymodel.h 846f39b 
>   src/collection/vocabularymodel.cpp 582701b 
>   src/editor/vocabularycolumnsdialog.cpp fc08c1e 
> 
> Diff: https://git.reviewboard.kde.org/r/130124/diff/
> 
> 
> Testing
> -------
> 
> Collections have been edited and practiced and everything worked as expected.
> 
> 
> File Attachments
> ----------------
> 
> Columns before
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/05/10/23f51bc0-e4a9-4372-a03f-6207d467fc95__parley_before.png
> Columns after
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/05/10/e4990fd0-c78b-44b8-a0ca-ec9a781080bc__parley_after.png
> 
> 
> Thanks,
> 
> Dimitris Kardarakos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20170726/57592717/attachment-0001.html>