Review Request 129873: Fix build with extra-cmake-modules > 5.30

Andreas Cord-Landwehr cordlandwehr at kde.org
Sun Jan 22 22:13:57 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129873/#review102195
-----------------------------------------------------------


Ship it!




Ouch, that seems to be a pretty old artifact. Thanks for the patch!

- Andreas Cord-Landwehr


On Jan. 22, 2017, 1:53 nachm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129873/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2017, 1:53 nachm.)
> 
> 
> Review request for KDE Edu and Andreas Cord-Landwehr.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Since a5f3a76e14799c68b5e8f74e375baa5f6f6ab4dc in
> extra-cmake-modules.git -fno-operator-names is passed to the build
> (when supported), causing a build error for kalzium.
> 
> 
> Diffs
> -----
> 
>   src/calculator/titrationCalculator.cpp 44ea1527 
> 
> Diff: https://git.reviewboard.kde.org/r/129873/diff/
> 
> 
> Testing
> -------
> 
> Builds fine now with ecm > 5.30.0
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20170122/c33b5639/attachment.html>


More information about the kde-edu mailing list