Review Request 129853: Honor the BUILD_TESTING cmake variable

Aleix Pol Gonzalez aleixpol at kde.org
Thu Jan 19 18:40:04 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129853/#review102100
-----------------------------------------------------------




CMakeLists.txt (line 265)
<https://git.reviewboard.kde.org/r/129853/#comment68243>

    `endif ()` according to our coding style.


Other than that, +1.

- Aleix Pol Gonzalez


On Jan. 19, 2017, 7:12 p.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129853/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 7:12 p.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> Honor the BUILD_TESTING cmake variable
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 94a7d426 
> 
> Diff: https://git.reviewboard.kde.org/r/129853/diff/
> 
> 
> Testing
> -------
> 
> Builds with and without BUILD_TESTING
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20170119/dddb5cb9/attachment.html>


More information about the kde-edu mailing list