D9573: Document "ReadyButton.qml"

Johnny Jazeix noreply at phabricator.kde.org
Sun Dec 31 16:41:31 UTC 2017


jjazeix added inline comments.

INLINE COMMENTS

> ReadyButton.qml:25
>  Rectangle {
> -    
> -    
> -    property string theme: "dark"
> +    id: iamReady
>  

iAmReady

> ReadyButton.qml:69
> +     */
>      border.color: themes[theme].borderColor
> +

no need to comment internal properties, only the ones exposed in the API

> ReadyButton.qml:75
> +     */
>      visible: true
> +

comment not useful, visible is self explained

> ReadyButton.qml:86
> +     */
>      gradient: Gradient {
>              GradientStop { position: 0 ; color: themes[theme].fillColor0 }

internal property (same for the ones below)

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D9573

To: amankumargupta, #gcompris_improvements
Cc: #kde_edu, jjazeix, #gcompris_improvements, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20171231/49044546/attachment.html>


More information about the kde-edu mailing list