D9360: Adding feature to change letters to capital and back (Ref: T5936)

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> LetterInWord.qml:69
>              property alias wordsModel: wordsModel
> +            property int currentLetterCase: 0
> +            property var letterCase: [

why don't you directly use the string value (not the text displayed, but a value associated to the combobox text)? It will be more explicit when used than the index

> LetterInWord.qml:70
> +            property int currentLetterCase: 0
> +            property var letterCase: [
> +                {"text": qsTr("Lower Case")},

as it is only used in the combobox (and not in the js file), it is better to declare it in the combobox

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D9360

To: rohitdas, #gcompris, #gcompris_improvements, jjazeix
Cc: jjazeix, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20171229/ec55402c/attachment.html>