D9475: submarine: Fix Vanne animations not working from keyboard controls
Rudra Nil Basu
noreply at phabricator.kde.org
Fri Dec 22 10:37:58 UTC 2017
rudranilbasu created this revision.
rudranilbasu added reviewers: jjazeix, timotheegiet.
Restricted Application added a subscriber: KDE Edu.
Restricted Application added a project: KDE Edu.
REVISION SUMMARY
Since most of the Animation Components attached to each of the Vannes of the
Ballast tanks do the same function, it is replaced with two functions ballastTankOnAnim
and ballastTankOffAnim, which is called via the updateVannes() function.
The updateVannes() function is also called from Submarine.qml, to fix the error of
the animations not being called via the keyboard controls.
Also fixed Vannes' state not updating on level changes by adding a reset() method
which sets the angle of the visible Vannes to zero
rotateLeftFill.angle = 0
rotateLeftFlush.angle = 0
rotateCentralFill.angle = 0
rotateCentralFlush.angle = 0
rotateRightFill.angle = 0
rotateRightFlush.angle = 0
REPOSITORY
R2 GCompris
REVISION DETAIL
https://phabricator.kde.org/D9475
AFFECTED FILES
src/activities/submarine/Controls.qml
src/activities/submarine/Submarine.qml
src/activities/submarine/submarine.js
To: rudranilbasu, jjazeix, timotheegiet
Cc: #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20171222/e037d8a6/attachment.html>
More information about the kde-edu
mailing list