D8859: Adapt the cmake buildsystem to be able to work with KDE CI

[Aleix Pol Gonzalez]

apol added a comment.


  In https://phabricator.kde.org/D8859#179037, @ckertesz wrote:
  
  > Currently, only the following SDK versions are able to build the KStars Android package:
  >
  > - Qt 5.10
  > - Android NDK 15c
  > - Android SDK with old platform tools v23.
  >
  >   Feedback:
  >
  >   You must patch cfitsio.patch with -p1 otherwise patch command can't apply it.
  
  
  Oops! Fixed. I wonder why it worked...
  
  >> I don't see where the issue in libraw is, can you see if the patching actually happened on your build?
  > 
  > Yes, the libraw patch must be applied otherwise "swab" symbol is undefined because the NDK system headers are messed between Android platform versions.
  >  Current problems:
  > 
  > - You can't remove this part of the libraw patch against CMakeLists.txt:
  > 
  >   +IF (ANDROID) +    INCLUDE_DIRECTORIES(${CMAKE_SOURCE_DIR}/android-hack) +ENDIF ()
  > - You can't remove this line of the libraw patch against CMakeLists.txt otherwise linking fails:
  > 
  >   +include(${CMAKE_TOOLCHAIN_FILE})
  
  Fixed and fixed.
  
  > Next problem:
  > 
  > - After everything built, the final linking fails because of the updated cfitsio version with linking error:
  > 
  >   [100%] Linking CXX shared library libkstars.so /cfitsio/cfileio.c:function fits_init_cfitsio: error: undefined reference to 'https_checkfile' /cfitsio/cfileio.c:function fits_init_cfitsio: error: undefined reference to 'https_open' /cfitsio/cfileio.c:function fits_init_cfitsio: error: undefined reference to 'https_file_open' /cfitsio/cfileio.c:function fits_init_cfitsio: error: undefined reference to 'https_checkfile' /cfitsio/cfileio.c:function fits_init_cfitsio: error: undefined reference to 'https_file_open'
  
  Rolled back the version to minimise the differences.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D8859

To: apol, mutlaqja
Cc: ckertesz, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20171220/5245a163/attachment.html>