D9395: Configuration capabilities for online dictionaries

[Dimitris Kardarakos]

dkardarakos created this revision.
dkardarakos added a reviewer: KDE Edu.
dkardarakos added a project: KDE Edu.

REVISION SUMMARY
  On-line dictionaries, until now, were hard coded to browser widget class. Instead of this, a new section has been added to configuration: Dictionaries. This section consists of a list of dictionaries and as a set of three buttons: Add, Edit, Remove. Initially, the list is loaded with the previously-hard coded dictionary entries, which are now configuration defaults. User may select an existing dictionary and edit or remove it. In case of editing, a dialog opens that enables the user to edit name, url, source language and target language. Moreover, user may press Add button so as to add a new dictionary entry. Finally, a set of error handling rules have been added, preventing the user from adding an entry with empty name or url.

TEST PLAN
  Check that in Settings, Dictionaries section has been added, containing a set of on-line dictionaries
  
  Add Dictionary
  
  - In Settings->Dictionaries, click Add. An editor opens.  Add a new dictionary entry. Click OK.
  
  A new dictionary is added to the list.
  
  Update Dictionary
  
  - In Settings->Dictionaries, select a dictionary, click Add.  An editor opens. Edit an existing dictionary entry. Click OK.
  
  Dictionary has been updated.
  
  Remove Dictionary
  
  - In Settings->Dictionaries, select a dictionary, click  Remove.
  
  Dictionary is removed from the list.
  
  Check buttons
  
  - In Settings->Dictionaries, ensure that no dictionary is selected.
  
  Edit, Remove buttons are not available.
  
  Apply
  
  - In Settings->Dictionaries, Add, Edit, Remove some dictionaries. Press OK/Apply.
  
  In Browser Widget, dictionary list displays the updated dictionary list.

REPOSITORY
  R340 Parley

REVISION DETAIL
  https://phabricator.kde.org/D9395

AFFECTED FILES
  src/CMakeLists.txt
  src/editor/browserwidget.cpp
  src/editor/browserwidget.h
  src/editor/editor.cpp
  src/editor/editor.h
  src/settings/dictionaryeditor.cpp
  src/settings/dictionaryeditor.h
  src/settings/dictionaryeditor.ui
  src/settings/parley.kcfg
  src/settings/parleyprefs.cpp
  src/settings/parleyprefs.h
  src/settings/webdictionary.ui
  src/settings/webdictoptions.cpp
  src/settings/webdictoptions.h
  src/settings/webdictoptions.ui

To: dkardarakos, #kde_edu
Cc: narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20171218/eb3a6951/attachment.html>