D9187: [Parley] Bugfix: StatisticsView doesn't display correct values

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Dec 11 00:00:58 UTC 2017


apol added a comment.


  Thanks!
  I'm not an expert in this codebase but the change looks sound to me.

INLINE COMMENTS

> statisticsmainwindow.h:43
>  
> -Q_SIGNALS:
> +signals:
>      void languagesChanged(int, int);

Why did you change this?
Please only change what's necessary for easier reviews.

> utils.cpp:295
>  }
> +
> +

Unrelated change

REPOSITORY
  R340 Parley

REVISION DETAIL
  https://phabricator.kde.org/D9187

To: hriesenbeck, #kde_edu
Cc: apol, narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20171211/ff0b5070/attachment.html>


More information about the kde-edu mailing list