Review Request 130224: fixes bug "Relative path for audio files not working"

[René Fritz]

> On Aug. 13, 2017, 3:42 p.m., Albert Astals Cid wrote:
> > Looks good, i'm going to go an extra step and ask.
> > 
> > Do you think you could either add an autotest (or improve one of the existing ones) to check this so we don't regress again?
> > 
> > If you think it's too much or need help, just say it :)

Hi,
Good point
I'm a developer but totally new to c++, qt, ...
So writing a test would be a bit too much for now, maybe?

I don't see how keduvockvtml2reader.cpp could be tested easily. Too much context I guess?

So testing to read a whole document might be the way to go. I looked into the existing tests. Kvtml2ReaderTest would be the right place I think and creating test entries in the fixture xml is something I could do I guess. But testing the parsed document would mean I understand the KVOCREADER_EXPECT_CORE macro to get access to the parsed document ... which is not the case :-)
A test example which takes 
XMLGenerator gen;
and makes
KEduVocDocument doc; 
out of it would be something I might be able to work with.


- René


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130224/#review103606
-----------------------------------------------------------


On Aug. 12, 2017, 8:20 p.m., René Fritz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130224/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2017, 8:20 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 381349
>     https://bugs.kde.org/show_bug.cgi?id=381349
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> description is in bug report https://bugs.kde.org/show_bug.cgi?id=381349
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/readerwriters/keduvockvtml2reader.cpp d5322f51266da66247248776430efa0cb7f98fdc 
> 
> Diff: https://git.reviewboard.kde.org/r/130224/diff/
> 
> 
> Testing
> -------
> 
> urls like "file:somepath/file.mp3" are parsed correctly again and sound is played
> 
> 
> Thanks,
> 
> René Fritz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20170813/06d5ee8d/attachment.html>