Review Request 130217: kbruch- Change QCheckBoxes under "Answer" section to QRadioButtons to avoid multiple checks.
Aman Kumar Gupta
gupta2140 at gmail.com
Sat Aug 5 06:19:34 UTC 2017
> On Aug. 4, 2017, 11:14 p.m., Aleix Pol Gonzalez wrote:
> > Screenshot for before and after?
Thank you very much. I will take care of it from next request onwards!
- Aman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130217/#review103547
-----------------------------------------------------------
On Aug. 5, 2017, 6:18 a.m., Aman Kumar Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130217/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2017, 6:18 a.m.)
>
>
> Review request for KDE Edu.
>
>
> Bugs: 357675
> http://bugs.kde.org/show_bug.cgi?id=357675
>
>
> Repository: kbruch
>
>
> Description
> -------
>
> Patch for Bug ID-357657. Replaced QCheckbox objects named "m_AnswerMixedCheck" and "m_ReducedCheck" to QRadioButton to select only one option in displaying the type of Answer(either Mixed Fraction or Reduced form).
>
>
> Diffs
> -----
>
> src/MainQtWidget.h dc62307
> src/MainQtWidget.cpp c522145
>
> Diff: https://git.reviewboard.kde.org/r/130217/diff/
>
>
> Testing
> -------
>
> It works successfully without any bugs fulfilling the objective of the patch. QCheckBoxes under "Answer Section" replaced with QRadioButtons, changes reflected to both, MainQtWidget.h as well as MainQtWidget.cpp.
>
>
> File Attachments
> ----------------
>
> Before patch. Both options under "Answer" checked.
> https://git.reviewboard.kde.org/media/uploaded/files/2017/08/05/07376b4b-7726-4c81-a581-9019912db46d__Mixedreduced_both_checked.png
> Before patch. Both options under "Answer" unchecked.
> https://git.reviewboard.kde.org/media/uploaded/files/2017/08/05/ccbe2e4b-b623-42a3-a17b-ce28b0aca972__Both_unchecked.png
> After patch. Changed QCheckBoxes to QRadiobuttons
> https://git.reviewboard.kde.org/media/uploaded/files/2017/08/05/5f659ff6-648f-4a94-808a-ecb754263449__Mixed_check.png
> Only one option out of Mixed and Reduced can be selected.
> https://git.reviewboard.kde.org/media/uploaded/files/2017/08/05/9466711e-bf9e-4133-967f-7965bffd4254__Reduced_check.png
>
>
> Thanks,
>
> Aman Kumar Gupta
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20170805/d24c074a/attachment.html>
More information about the kde-edu
mailing list