Review Request 130104: kgeography: Add location name in results table

Albert Astals Cid aacid at kde.org
Tue Apr 25 21:15:47 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130104/#review103131
-----------------------------------------------------------


Ship it!




Looks good, thanks :)

- Albert Astals Cid


On April 24, 2017, 10:15 a.m., Dimitris Kardarakos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130104/
> -----------------------------------------------------------
> 
> (Updated April 24, 2017, 10:15 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 141442
>     http://bugs.kde.org/show_bug.cgi?id=141442
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> In "Location of Countries" quiz, the table of results displays only the color of the user answer. As mentioned in bug report, in maps with many countries, it could be useful to display the name of the location selected by the user. So, results table has been enhanced displaying location names as well.
> 
> 
> Diffs
> -----
> 
>   src/answer.cpp 404d409 
>   src/map.h a1db524 
>   src/map.cpp 5bb723b 
>   src/mapasker.cpp c5f1113 
> 
> Diff: https://git.reviewboard.kde.org/r/130104/diff/
> 
> 
> Testing
> -------
> 
> Executed quiz of putting locations to map, using various maps. Results table displays the name of the selected by the user location.
> 
> 
> Thanks,
> 
> Dimitris Kardarakos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20170425/67eca75c/attachment.html>


More information about the kde-edu mailing list