Review Request 128523: Fix regression where INDI version check is ignored.
Jasem Mutlaq
mutlaqja at ikarustech.com
Wed Sep 21 15:40:42 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128523/#review99380
-----------------------------------------------------------
Ship it!
Ship It!
- Jasem Mutlaq
On Sept. 15, 2016, 4:14 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128523/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2016, 4:14 p.m.)
>
>
> Review request for KDE Edu and KStars.
>
>
> Repository: kstars
>
>
> Description
> -------
>
> 40cf6ad6cd9a8773b78da828daf98069f4777d76 introduced a regression where any
> version of INDI was accepted, even if it did not meet the minimum version
> requirement.
>
>
> Diffs
> -----
>
> cmake/modules/FindINDI.cmake 1b7b43976e42b0ba310ed21006e3e8dab87790d6
>
> Diff: https://git.reviewboard.kde.org/r/128523/diff/
>
>
> Testing
> -------
>
> INDI 1.1.0 is now ignored instead of build failing. Build still passes with INDI 1.2.0.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160921/dcd89b8c/attachment.html>
More information about the kde-edu
mailing list