Review Request 128926: More robust version check for Sage

[Antonio Rojas]

> On Sept. 19, 2016, 3:07 p.m., Filipe Saraiva wrote:
> > Oh man! 0_0
> > Which Sage version is not detected currently?
> > Did you try if your approach works with previous version of Sage?

Good point, it seems 'sage --dumpversion' was introduced in 6.6, so it obviously doesn't make sense to use it to detect if the version is < 5.7. I changed it to use 'sage -v' instead, which has been there forever.

Should have mentioned it, this affects the (not yet released) Sage 7.4 version, which uses iPython 5 (and also the 5.3 version from Arch repos, which also uses it). iPython 5 moved from using readline to the prompt_toolkit library, so it will require major refactoring of the Sage backend :( This is just one small step.


- Antonio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128926/#review99277
-----------------------------------------------------------


On Sept. 19, 2016, 8:24 p.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128926/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 8:24 p.m.)
> 
> 
> Review request for KDE Edu and Filipe Saraiva.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Version check for Sage is once again broken with the latest version. Instead of relying on parsing the sage banner, which is likely to break with changes in Sage output format, use the dedicated 'sage --dumpversion' command.
> 
> 
> Diffs
> -----
> 
>   src/backends/sage/sagesession.cpp bd2c3dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128926/diff/
> 
> 
> Testing
> -------
> 
> Correct version is detected again according to the console output. Note that the backend is still broken with latest Sage, but that's a separate issue.
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160919/ed53d946/attachment.html>