Review Request 128926: More robust version check for Sage

[Aleix Pol Gonzalez]

> On Sept. 17, 2016, 12:17 a.m., Aleix Pol Gonzalez wrote:
> > src/backends/sage/sagesession.cpp, line 201
> > <https://git.reviewboard.kde.org/r/128926/diff/1/?file=476967#file476967line201>
> >
> >     You can `split('.')`, also you can use `splitRef('.')` which will reduce allocations by a bunch.
> 
> Antonio Rojas wrote:
>     Using ('.') gives error: ‘QChar::QChar(char)’ is private within this context

You need to use QCharLiteral('.') or QLatin1Char('.') I guess?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128926/#review99236
-----------------------------------------------------------


On Sept. 17, 2016, 1:05 p.m., Antonio Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128926/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2016, 1:05 p.m.)
> 
> 
> Review request for KDE Edu and Filipe Saraiva.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Version check for Sage is once again broken with the latest version. Instead of relying on parsing the sage banner, which is likely to break with changes in Sage output format, use the dedicated 'sage --dumpversion' command.
> 
> 
> Diffs
> -----
> 
>   src/backends/sage/sagesession.cpp bd2c3dc 
> 
> Diff: https://git.reviewboard.kde.org/r/128926/diff/
> 
> 
> Testing
> -------
> 
> Correct version is detected again according to the console output. Note that the backend is still broken with latest Sage, but that's a separate issue.
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160918/95fbff03/attachment.html>